Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/SOF-7544 cleanups #314

Merged
merged 21 commits into from
Jan 17, 2025
Merged

Update/SOF-7544 cleanups #314

merged 21 commits into from
Jan 17, 2025

Conversation

VsevolodX
Copy link
Member

No description provided.

Copy link

netlify bot commented Jan 3, 2025

Deploy Preview for mat3ra-documentation ready!

Name Link
🔨 Latest commit 0f70ad9
🔍 Latest deploy log https://app.netlify.com/sites/mat3ra-documentation/deploys/677de22880216e00085cae1b
😎 Deploy Preview https://deploy-preview-314--mat3ra-documentation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


1. **Giacomo Miceli, Alfredo Pasquarello**,
"Self-compensation due to point defects in Mg-doped GaN", Physical Review B, 2016.
[DOI: 10.1103/PhysRevB.93.165207](https://journals.aps.org/prb/abstract/10.1103/PhysRevB.93.165207){:target='_blank'}.

## Tags
## Tags.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use the in-built tags feature - https://squidfunk.github.io/mkdocs-material/setup/setting-up-tags/

In that case, we need to specify the tags on the top/frontmatter (also tags are shown on the top of the page):

---
tags:
  - defects
  - defect pair
---

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to use them anywhere currently, do we?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we need to place them before

# YAML header
render_macros: true

And also set to hide:

hide:
   - tags

For desired display

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, we used tags to set YouTube hashtags. But they are set via JSON metadata (e.g., https://github.com/Exabyte-io/documentation/blob/master/lang/en/docs/metadata/general.json). We may think of modifying the tags plugin to include tags from JSON files and extend them.

@VsevolodX VsevolodX marked this pull request as ready for review January 6, 2025 22:34
@VsevolodX VsevolodX merged commit 1261716 into master Jan 17, 2025
11 checks passed
@VsevolodX VsevolodX deleted the update/SOF-7544 branch January 17, 2025 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants